-
Notifications
You must be signed in to change notification settings - Fork 2
Improve async testing #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## async #226 +/- ##
==========================================
- Coverage 81.43% 81.41% -0.02%
==========================================
Files 36 36
Lines 7378 7377 -1
==========================================
- Hits 6008 6006 -2
- Misses 1370 1371 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Change test case
test_pulse_collection_consumptionto testing at the same, frozen time, this will result in predicable test result for pulses collected over 24 hrs.This change also resulted in finding a small bug in the actual code.