Add a JS preview of the payment amount to the new payment form#61
Draft
jhenstridge wants to merge 3 commits intomainfrom
Draft
Add a JS preview of the payment amount to the new payment form#61jhenstridge wants to merge 3 commits intomainfrom
jhenstridge wants to merge 3 commits intomainfrom
Conversation
jhenstridge
force-pushed
the
payment-amount-preview
branch
3 times, most recently
from
539df47 to
3101772
Compare
Also convert the form to regular tabular layout rather than squashing it into prose.
jhenstridge
force-pushed
the
payment-amount-preview
branch
from
3101772 to
1935f4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a clean-up for the payment form to use a more standard layout, and to show the amount the payment will be recorded as. Here is what the changed UI looks like:
The eventual goal is to let us record the payment with the actual dollar amount for when people provide additional donations, or if we grant a complementary membership (as described in #53). I'm not completely sure what the UI for that should look like though.