Fix uninstall#462
Merged
Merged
Conversation
Rom1-B
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When GLPI migrates data into the core, the itemtype column of the glpi_plugin_genericobject_types table is also updated.
For example:
PluginGenericObjectAntenne→Glpi\CustomAsset\AntenneAssetThe plugin’s uninstallation process relies on this column to locate and remove the corresponding files, classes, and MySQL tables.
Under these conditions, the plugin ends up deleting the glpi_assets_assets table.
This pull request also removes the
/files/_plugins/genericobject/directory at the end of the uninstall process, as it contains folders that were added after theuninstallmethod was originally implemented.Similarly, when dropping tables, a length check is now performed on the table name to prevent the following MySQL error:
Screenshots (if appropriate):