Fix - Check method existence before calling uninstall on custom assets#460
Merged
Conversation
stonebuzz
approved these changes
Nov 10, 2025
Rom1-B
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Problem:
After migrating to GLPI 11, uninstalling the GenericObject plugin fails with
UndefinedMethodErrorwhen trying to calluninstall()on Custom Asset classes that don't have this method.Root cause:
GenericObject items are migrated to native GLPI Custom Assets (
Glpi\CustomAsset\*namespace) which don't implement theuninstall()method.Solution:
Add
method_exists()check before callinguninstall()inhook.phpto handle both legacy GenericObject classes and new Custom Assets.