Skip to content

Fix(Core): Fix plugin name label #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 3 commits into from
Oct 1, 2025
Merged

Fix(Core): Fix plugin name label #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4840301
Fix(Core): Fix plugin name label
stonebuzz Oct 1, 2025
fc3ea92
fix uninstall
stonebuzz Oct 1, 2025
9cbd3e1
secure drop table
stonebuzz Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inc/profile.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ public static function uninstall()
{
/** @var DBmysql $DB */
global $DB;
$DB->dropTable('glpi_profilerights');
$query = "DELETE FROM `glpi_profilerights`
WHERE `name` LIKE '%plugin_genericobject%'";
$DB->doQuery($query);
}
}
4 changes: 3 additions & 1 deletion inc/type.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,8 @@ public static function uninstall()
/** @var DBmysql $DB */
global $DB;

$migration = new Migration(PLUGIN_GENERICOBJECT_VERSION);

//Delete references to PluginGenericobjectType in the following tables
self::deleteItemtypeReferencesInGLPI(self::class);

Expand All @@ -665,7 +667,7 @@ public static function uninstall()
}

//Delete table
$DB->dropTable('glpi_plugin_genericobject_types', true);
$migration->dropTable('glpi_plugin_genericobject_types');
}


Expand Down
3 changes: 2 additions & 1 deletion inc/typefamily.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ public static function uninstall()
/** @var DBmysql $DB */
global $DB;

$migration = new Migration(PLUGIN_GENERICOBJECT_VERSION);
$table = getTableForItemType(self::class);
$DB->dropTable($table, true);
$migration->dropTable($table);
}
}
2 changes: 1 addition & 1 deletion setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function plugin_init_genericobject()
function plugin_version_genericobject()
{
return [
'name' => __s("Objects management (Migration Only)", "genericobject"),
'name' => __s("Generic Objects End-of-Life Updater", "genericobject"),
'version' => PLUGIN_GENERICOBJECT_VERSION,
'author' => "<a href=\"mailto:contact@teclib.com\">Teclib'</a> & siprossii",
'homepage' => 'https://github.com/pluginsGLPI/genericobject',
Expand Down