Skip to content

Migration genericobject fields to core#996

Merged
stonebuzz merged 9 commits into
feature/glpi-11.0from
migration_genericobject_fields_to_core
Sep 29, 2025
Merged

Migration genericobject fields to core#996
stonebuzz merged 9 commits into
feature/glpi-11.0from
migration_genericobject_fields_to_core

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Since the genericobject plugin has been replaced natively by Assets in glpi11, this PR migrates the fields for assets.

Replace: #992

TODO

  • Check that the plugin is up to date (latest version).
  • Check the existence and integrity of the glpi_plugin_genericobject_types table.
  • Fix the escape bug with itemtypes. For example, the itemtype Glpi\CustomAsset\telephoneAsset becomes Glpi\CustomAsset\ elephoneAsset because the \t sequence is not correctly escaped and is interpreted as a tab.
  • Test with large tables.

@Rom1-B Rom1-B force-pushed the migration_genericobject_fields_to_core branch 3 times, most recently from 281bce6 to a290373 Compare August 20, 2025 14:18
@Rom1-B Rom1-B force-pushed the migration_genericobject_fields_to_core branch from 76e0c06 to 15952c2 Compare August 21, 2025 09:21
@Rom1-B Rom1-B requested a review from stonebuzz August 26, 2025 10:04
@Rom1-B Rom1-B requested a review from MyvTsv September 15, 2025 08:18
Comment thread inc/container.class.php Outdated
@stonebuzz stonebuzz merged commit 0cbad0c into feature/glpi-11.0 Sep 29, 2025
3 checks passed
@stonebuzz stonebuzz deleted the migration_genericobject_fields_to_core branch September 29, 2025 12:59
stonebuzz pushed a commit that referenced this pull request Sep 29, 2025
* genericobject compatibility

* review

* glpi_plugin_genericobject_types

* Check GenericObject version

* Check glpi_plugin_genericobject_types table

* fix escape

* fix check version

* fix(customasset): handle escaped backslashes in json decode itemtypes

* Apply suggestion from @Rom1-B

---------

Co-authored-by: MyuTsu <gaetan.langlois31@gmail.com>
Rom1-B added a commit that referenced this pull request Sep 30, 2025
* GLPI 11 compatibility

* Apply suggestions

* Fix phpstan

* Fix massive actions error

* Fix direct queries

* Update inc/containerdisplaycondition.class.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update front/container.form.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update front/container.form.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update ajax/container.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update ajax/container.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update ajax/container.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* Update ajax/container.php

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>

* beta2

* typo

* fix phpstan

* fix path

* Fix item link for container list

* Fix reference

* Migration genericobject fields to core (#996)

* genericobject compatibility

* review

* glpi_plugin_genericobject_types

* Check GenericObject version

* Check glpi_plugin_genericobject_types table

* fix escape

* fix check version

* fix(customasset): handle escaped backslashes in json decode itemtypes

* Apply suggestion from @Rom1-B

---------

Co-authored-by: MyuTsu <gaetan.langlois31@gmail.com>

* beta3

* fix CS

* release GLPI 11.0

---------

Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Rom1-B <rom1.biot@gmail.com>
Co-authored-by: Stanislas Kita <skita@teclib.com>
Co-authored-by: Johan Cwiklinski <johan@x-tnd.be>
Co-authored-by: MyuTsu <gaetan.langlois31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants