Skip to content

Fix - Prevent unnecessary container refresh breaking mandatory field validation #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 1 commit into from
Oct 23, 2025
Merged

Fix - Prevent unnecessary container refresh breaking mandatory field validation #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions inc/field.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,9 @@ function(obj, item) {
{}
);

// Check current visibility state before refresh
const wasVisible = $('#{$html_id}').children().length > 0;

$.ajax(
{
url: '{$ajax_url}',
Expand All @@ -1009,10 +1012,18 @@ function(obj, item) {
input: data
},
success: function(data) {
// Close open select2 dropdown that will be replaced
$('#{$html_id}').find('.select2-hidden-accessible').select2('close');
// Refresh fields HTML
$('#{$html_id}').html(data);
// Check if visibility will change
const willBeVisible = data.trim() !== '';

// Only refresh if visibility state changes
// This prevents unnecessary DOM replacement that breaks validation event listeners
if (wasVisible !== willBeVisible) {
// Close open select2 dropdown that will be replaced
$('#{$html_id}').find('.select2-hidden-accessible').select2('close');

// Refresh fields HTML
$('#{$html_id}').html(data);
}
}
}
);
Expand Down