prevent non existing key "bypass_filter_assign_group" in ticket.class…

[CorentinS6]

….php

fix PHP Warning (2): Undefined array key "bypass_filter_assign_group" in /var/www/glpi/plugins/escalade/inc/ticket.class.php at line 1270

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes # (issue number, if applicable)
• Here is a brief description of what this PR does

Screenshots (if appropriate):

[stonebuzz]

Suggested change

	if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) {
	if ($config->fields['use_filter_assign_group'] && (!isset($user_config->fields['bypass_filter_assign_group']) || !$user_config->fields['bypass_filter_assign_group'])) {

[Rom1-B]

Suggested change

	if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) {
	if ($config->fields['use_filter_assign_group'] ?? false && !($user_config->fields['bypass_filter_assign_group'] ?? false)) {

[stonebuzz]

Please use / test the second proposal and let me know if it works for you.

[FrancisTicgal]

Hello,
Can we put something like this? The problem I see is when the user does not exist in the escalade_users table.

if (
     $config->fields['use_filter_assign_group']
    && isset($user_config->fields['bypass_filter_assign_group'])
    && !$user_config->fields['bypass_filter_assign_group']
) {
    $condition['id'] = $groups_id_filtered;
}

-- edit
I hadn't seen Corentin's commit, but I agree with him.
If the configuration field were missing, the problem would be different in my opinion, but the existence of the user configuration is not checked, so new users might not have it.

[FrancisTicgal]

I add screenshots for context