fix: resolve circular import in event connector refactoring#208
Closed
Copilot wants to merge 2 commits intorefactor/event-connector-uxfrom
Closed
fix: resolve circular import in event connector refactoring#208Copilot wants to merge 2 commits intorefactor/event-connector-uxfrom
Copilot wants to merge 2 commits intorefactor/event-connector-uxfrom
Conversation
Moved EventConnectorSpecBuilder import to be a late import inside the build_event_connectors method to break the circular dependency chain: - connector -> connector_builder -> event_connector_spec_builder -> component -> io_controller -> connector The late import ensures the module is only loaded when the method is called, after all other modules are fully initialized. Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor event connector UX for simplified user experience
fix: resolve circular import in event connector refactoring
Feb 7, 2026
Contributor
|
Rejecting in favour or 18b96d5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes circular import introduced in the event connector UX refactoring. The module-level import of
EventConnectorSpecBuilderinconnector_builder.pycreated a dependency cycle:connector→connector_builder→event_connector_spec_builder→component→io_controller→connector.Changes
EventConnectorSpecBuilderimport from module level to insidebuild_event_connectors()method inconnector_builder.py💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.