test: replace substring with slice for consistency

JBR-0100 · JBR-0100 · commit 12f53ea4be18 · 2025-12-04T04:08:55.000+05:30
Replaced substring() with slice() in test files to maintain
consistency with the source code changes where substr() was
replaced with slice().
diff --git a/test/jasmine/assets/get_bbox.js b/test/jasmine/assets/get_bbox.js
@@ -15,7 +15,7 @@ module.exports = function getBBox(element) {
     if(!clipPathAttr) return elementBBox;
 
     // only supports 'url(#<id>)' at the moment
-    var clipPathId = clipPathAttr.substring(5, clipPathAttr.length - 1);
+    var clipPathId = clipPathAttr.slice(5, clipPathAttr.length - 1);
     var clipBBox = getClipBBox(clipPathId);
 
     return minBBox(elementBBox, clipBBox);
diff --git a/test/jasmine/tests/annotations_test.js b/test/jasmine/tests/annotations_test.js
@@ -1289,7 +1289,7 @@ describe('annotation effects', function() {
             // AJ loosened this test - expected '2017-02-02 06:36:46.8112'
             // but when I run it I get '2017-02-02 06:28:39.9586'.
             // must be different fonts altering autoranging
-            expect(gd._fullLayout.annotations[0].y.substring(0, 10)).toBe('2017-02-02');
+            expect(gd._fullLayout.annotations[0].y.slice(0, 10)).toBe('2017-02-02');
         })
         .then(done, done.fail);
     });
diff --git a/test/jasmine/tests/axes_test.js b/test/jasmine/tests/axes_test.js
@@ -833,7 +833,7 @@ describe('Test axes', function() {
         it('breaks scaleanchor loops and drops conflicting ratios', function() {
             var warnings = [];
             spyOn(Lib, 'warn').and.callFake(function(msg) {
-                warnings.push(msg.substring(0, msg.indexOf(' to avoid')));
+                warnings.push(msg.slice(0, msg.indexOf(' to avoid')));
             });
 
             layoutIn = {
@@ -868,7 +868,7 @@ describe('Test axes', function() {
         it('silently drops invalid scaleanchor values', function() {
             var warnings = [];
             spyOn(Lib, 'warn').and.callFake(function(msg) {
-                warnings.push(msg.substring(0, msg.indexOf(' to avoid')));
+                warnings.push(msg.slice(0, msg.indexOf(' to avoid')));
             });
 
             layoutIn = {
diff --git a/test/jasmine/tests/bar_test.js b/test/jasmine/tests/bar_test.js
@@ -2170,7 +2170,7 @@ describe('A bar plot', function() {
 
     function getArea(path) {
         var pos = path
-            .substring(1, path.length - 1)
+            .slice(1, path.length - 1)
             .replace('V', ',')
             .replace('H', ',')
             .replace('V', ',')
@@ -3258,7 +3258,7 @@ describe('bar uniformtext', function() {
                 if(pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +(transform.substring(pos0, pos1));
+                    scale = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/funnel_test.js b/test/jasmine/tests/funnel_test.js
@@ -1664,7 +1664,7 @@ describe('funnel uniformtext', function() {
                 if(pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +(transform.substring(pos0, pos1));
+                    scale = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/funnelarea_test.js b/test/jasmine/tests/funnelarea_test.js
@@ -1737,7 +1737,7 @@ describe('funnelarea uniformtext', function() {
                 if(pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +(transform.substring(pos0, pos1));
+                    scale = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/lib_date_test.js b/test/jasmine/tests/lib_date_test.js
@@ -261,7 +261,7 @@ describe('dates', function() {
             for(var i = -1; i <= 1; i += 0.001) {
                 var tenths = Math.round(i * 10);
                 var base = i < -0.05 ? '1969-12-31 23:59:59.99' : '1970-01-01 00:00:00.00';
-                var expected = (base + String(tenths + 200).substring(1))
+                var expected = (base + String(tenths + 200).slice(1))
                     .replace(/0+$/, '')
                     .replace(/ 00:00:00[\.]$/, '');
                 expect(Lib.ms2DateTime(i)).toBe(expected, i);
diff --git a/test/jasmine/tests/lib_number_format_test.js b/test/jasmine/tests/lib_number_format_test.js
@@ -115,7 +115,7 @@ describe('number format', function() {
 
             if(format.indexOf('(') === 0) {
                 posExp = exp.replace('+', ' ');
-                negExp = exp.replace('+', '(').substring(1) + ')';
+                negExp = exp.replace('+', '(').slice(1) + ')';
             } else if(format.indexOf('+') === 0) {
                 negExp = exp.replace('+', '-');
             } else if(format.indexOf('-') === 0) {
diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js
@@ -1040,7 +1040,7 @@ describe('ModeBar', function() {
             var actual = ax.range;
 
             if(ax.type === 'date') {
-                var truncate = function(v) { return v.substring(0, 10); };
+                var truncate = function(v) { return v.slice(0, 10); };
                 expect(actual.map(truncate)).toEqual(expected.map(truncate), axName);
             } else {
                 expect(actual).toBeCloseToArray(expected, PRECISION, axName);
diff --git a/test/jasmine/tests/pie_test.js b/test/jasmine/tests/pie_test.js
@@ -1779,7 +1779,7 @@ describe('pie inside text orientation', function() {
                 if(pos0 !== -1) {
                     pos0 += 'rotate('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    rotate = +(transform.substring(pos0, pos1));
+                    rotate = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.rotations[i]).toBeCloseTo(rotate, -1, 'rotation for element ' + i, msg);
@@ -1879,7 +1879,7 @@ describe('pie uniformtext', function() {
                 if(pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +(transform.substring(pos0, pos1));
+                    scale = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/plot_interact_test.js b/test/jasmine/tests/plot_interact_test.js
@@ -545,8 +545,8 @@ describe('plot svg clip paths', function() {
             d3SelectAll('[clip-path]').each(function() {
                 var cp = d3Select(this).attr('clip-path');
 
-                expect(cp.substring(0, 5)).toEqual('url(#');
-                expect(cp.substring(cp.length - 1)).toEqual(')');
+                expect(cp.slice(0, 5)).toEqual('url(#');
+                expect(cp.slice(cp.length - 1)).toEqual(')');
             });
         })
         .then(done, done.fail);
@@ -568,8 +568,8 @@ describe('plot svg clip paths', function() {
             d3SelectAll('[clip-path]').each(function() {
                 var cp = d3Select(this).attr('clip-path');
 
-                expect(cp.substring(0, 6 + href.length)).toEqual('url(\'' + href + '#');
-                expect(cp.substring(cp.length - 2)).toEqual('\')');
+                expect(cp.slice(0, 6 + href.length)).toEqual('url(\'' + href + '#');
+                expect(cp.slice(cp.length - 2)).toEqual('\')');
             });
 
             base.remove();
diff --git a/test/jasmine/tests/shapes_test.js b/test/jasmine/tests/shapes_test.js
@@ -1642,7 +1642,7 @@ describe('Test shapes', function() {
             var xParams = constants.paramIsX[segmentType];
             var yParams = constants.paramIsY[segmentType];
             var nParams = constants.numParams[segmentType];
-            var params = segment.substring(1).match(constants.paramRE);
+            var params = segment.slice(1).match(constants.paramRE);
 
             if(params) {
                 params.forEach(function(param) {
diff --git a/test/jasmine/tests/snapshot_test.js b/test/jasmine/tests/snapshot_test.js
@@ -252,7 +252,7 @@ describe('Plotly.Snapshot', function() {
         describe('should handle quoted style properties', function() {
             function checkURL(actual, msg) {
                 // which is enough tot check that toSVG did its job right
-                expect((actual || '').substring(0, 6)).toBe('url(\"#', msg);
+                expect((actual || '').slice(0, 6)).toBe('url(\"#', msg);
             }
 
             it('- marker-gradient case', function(done) {
diff --git a/test/jasmine/tests/sunburst_test.js b/test/jasmine/tests/sunburst_test.js
@@ -2745,7 +2745,7 @@ describe('sunburst inside text orientation', function () {
                 if (pos0 !== -1) {
                     pos0 += 'rotate('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    rotate = +transform.substring(pos0, pos1);
+                    rotate = +transform.slice(pos0, pos1);
                 }
 
                 expect(opts.rotations[i]).toBeCloseTo(rotate, -1, 'rotation for element ' + i, msg);
@@ -2853,7 +2853,7 @@ describe('sunburst uniformtext', function () {
                 if (pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +transform.substring(pos0, pos1);
+                    scale = +transform.slice(pos0, pos1);
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/toimage_test.js b/test/jasmine/tests/toimage_test.js
@@ -247,12 +247,12 @@ describe('Plotly.toImage', function() {
             var clipPath = gSubplot.getAttribute('clip-path');
             var len = clipPath.length;
 
-            var head = clipPath.substring(0, 4);
-            var tail = clipPath.substring(len - 7, len);
+            var head = clipPath.slice(0, 4);
+            var tail = clipPath.slice(len - 7, len);
             expect(head).toBe('url(', 'subplot clipPath head');
             expect(tail).toBe('xyplot)', 'subplot clipPath tail');
 
-            var middle = clipPath.substring(4, 14);
+            var middle = clipPath.slice(4, 14);
             expect(middle.length).toBe(10, 'subplot clipPath uid length');
             expect(middle.indexOf('http://')).toBe(-1, 'no <base> URL in subplot clipPath!');
             expect(middle.indexOf('https://')).toBe(-1, 'no <base> URL in subplot clipPath!');
diff --git a/test/jasmine/tests/treemap_test.js b/test/jasmine/tests/treemap_test.js
@@ -2141,7 +2141,7 @@ describe('treemap uniformtext', function () {
                 if (pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +transform.substring(pos0, pos1);
+                    scale = +transform.slice(pos0, pos1);
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);
diff --git a/test/jasmine/tests/waterfall_test.js b/test/jasmine/tests/waterfall_test.js
@@ -1830,7 +1830,7 @@ describe('waterfall uniformtext', function() {
                 if(pos0 !== -1) {
                     pos0 += 'scale('.length;
                     var pos1 = transform.indexOf(')', pos0);
-                    scale = +(transform.substring(pos0, pos1));
+                    scale = +(transform.slice(pos0, pos1));
                 }
 
                 expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);

Original file line number	Diff line number	Diff line change
`@@ -1664,7 +1664,7 @@ describe('funnel uniformtext', function() {`
`1664`	`1664`	`if(pos0 !== -1) {`
`1665`	`1665`	`pos0 += 'scale('.length;`
`1666`	`1666`	`var pos1 = transform.indexOf(')', pos0);`
`1667`		`- scale = +(transform.substring(pos0, pos1));`
	`1667`	`+ scale = +(transform.slice(pos0, pos1));`
`1668`	`1668`	`}`
`1669`	`1669`
`1670`	`1670`	`expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);`
Original file line number	Diff line number	Diff line change
`@@ -1737,7 +1737,7 @@ describe('funnelarea uniformtext', function() {`
`1737`	`1737`	`if(pos0 !== -1) {`
`1738`	`1738`	`pos0 += 'scale('.length;`
`1739`	`1739`	`var pos1 = transform.indexOf(')', pos0);`
`1740`		`- scale = +(transform.substring(pos0, pos1));`
	`1740`	`+ scale = +(transform.slice(pos0, pos1));`
`1741`	`1741`	`}`
`1742`	`1742`
`1743`	`1743`	`expect(opts.scales[i]).toBeCloseTo(scale, 1, 'scale for element ' + i, msg);`