test: replace substr with substring in test files

Author: JBR-0100

test/jasmine/tests/annotations_test.js

@@ -1289,7 +1289,7 @@ describe('annotation effects', function() {
             // AJ loosened this test - expected '2017-02-02 06:36:46.8112'
             // but when I run it I get '2017-02-02 06:28:39.9586'.
             // must be different fonts altering autoranging
-            expect(gd._fullLayout.annotations[0].y.substr(0, 10)).toBe('2017-02-02');
+            expect(gd._fullLayout.annotations[0].y.substring(0, 10)).toBe('2017-02-02');
         })
         .then(done, done.fail);
     });

test/jasmine/tests/axes_test.js

@@ -833,7 +833,7 @@ describe('Test axes', function() {
         it('breaks scaleanchor loops and drops conflicting ratios', function() {
             var warnings = [];
             spyOn(Lib, 'warn').and.callFake(function(msg) {
-                warnings.push(msg.substr(0, msg.indexOf(' to avoid')));
+                warnings.push(msg.substring(0, msg.indexOf(' to avoid')));
             });
 
             layoutIn = {
@@ -868,7 +868,7 @@ describe('Test axes', function() {
         it('silently drops invalid scaleanchor values', function() {
             var warnings = [];
             spyOn(Lib, 'warn').and.callFake(function(msg) {
-                warnings.push(msg.substr(0, msg.indexOf(' to avoid')));
+                warnings.push(msg.substring(0, msg.indexOf(' to avoid')));
             });
 
             layoutIn = {

test/jasmine/tests/bar_test.js

@@ -2170,7 +2170,7 @@ describe('A bar plot', function() {
 
     function getArea(path) {
         var pos = path
-            .substr(1, path.length - 2)
+            .substring(1, path.length - 1)
             .replace('V', ',')
             .replace('H', ',')
             .replace('V', ',')

test/jasmine/tests/lib_date_test.js

@@ -261,7 +261,7 @@ describe('dates', function() {
             for(var i = -1; i <= 1; i += 0.001) {
                 var tenths = Math.round(i * 10);
                 var base = i < -0.05 ? '1969-12-31 23:59:59.99' : '1970-01-01 00:00:00.00';
-                var expected = (base + String(tenths + 200).substr(1))
+                var expected = (base + String(tenths + 200).substring(1))
                     .replace(/0+$/, '')
                     .replace(/ 00:00:00[\.]$/, '');
                 expect(Lib.ms2DateTime(i)).toBe(expected, i);

test/jasmine/tests/modebar_test.js

@@ -1040,7 +1040,7 @@ describe('ModeBar', function() {
             var actual = ax.range;
 
             if(ax.type === 'date') {
-                var truncate = function(v) { return v.substr(0, 10); };
+                var truncate = function(v) { return v.substring(0, 10); };
                 expect(actual.map(truncate)).toEqual(expected.map(truncate), axName);
             } else {
                 expect(actual).toBeCloseToArray(expected, PRECISION, axName);

test/jasmine/tests/shapes_test.js

@@ -1642,7 +1642,7 @@ describe('Test shapes', function() {
             var xParams = constants.paramIsX[segmentType];
             var yParams = constants.paramIsY[segmentType];
             var nParams = constants.numParams[segmentType];
-            var params = segment.substr(1).match(constants.paramRE);
+            var params = segment.substring(1).match(constants.paramRE);
 
             if(params) {
                 params.forEach(function(param) {

test/jasmine/tests/snapshot_test.js

@@ -252,7 +252,7 @@ describe('Plotly.Snapshot', function() {
         describe('should handle quoted style properties', function() {
             function checkURL(actual, msg) {
                 // which is enough tot check that toSVG did its job right
-                expect((actual || '').substr(0, 6)).toBe('url(\"#', msg);
+                expect((actual || '').substring(0, 6)).toBe('url(\"#', msg);
             }
 
             it('- marker-gradient case', function(done) {

test/jasmine/tests/toimage_test.js

@@ -247,12 +247,12 @@ describe('Plotly.toImage', function() {
             var clipPath = gSubplot.getAttribute('clip-path');
             var len = clipPath.length;
 
-            var head = clipPath.substr(0, 4);
-            var tail = clipPath.substr(len - 7, len);
+            var head = clipPath.substring(0, 4);
+            var tail = clipPath.substring(len - 7, len);
             expect(head).toBe('url(', 'subplot clipPath head');
             expect(tail).toBe('xyplot)', 'subplot clipPath tail');
 
-            var middle = clipPath.substr(4, 10);
+            var middle = clipPath.substring(4, 14);
             expect(middle.length).toBe(10, 'subplot clipPath uid length');
             expect(middle.indexOf('http://')).toBe(-1, 'no <base> URL in subplot clipPath!');
             expect(middle.indexOf('https://')).toBe(-1, 'no <base> URL in subplot clipPath!');