Skip to content

Fix misaligned slider marks with empty labels#3723

Open
terminalchai wants to merge 1 commit intoplotly:devfrom
terminalchai:fix-slider-mark-height
Open

Fix misaligned slider marks with empty labels#3723
terminalchai wants to merge 1 commit intoplotly:devfrom
terminalchai:fix-slider-mark-height

Conversation

@terminalchai
Copy link
Copy Markdown

Summary

  • add an explicit height: 12px to .dash-slider-mark so empty labels keep the same mark box height as labeled marks
  • add an integration regression test covering the empty-string marks case from #3715

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • add the slider mark height fix
    • add a regression test for empty mark labels
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Fixes #3715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bad behaviour] dcc.Slider marks misaligned with empty label in Dash 4

1 participant