Skip to content
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6b6b551
Bump AG Grid version
KoolADE85 Jul 2, 2025
04f8c28
Remove rowSelection from AG Grid props
KoolADE85 Jul 3, 2025
10d17d1
Memoize component
KoolADE85 Jul 4, 2025
222ad7e
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 Jul 4, 2025
6fd20f8
Include sparklines module from ag-grid-enterprise
KoolADE85 Jul 10, 2025
1039821
Upgrade to AG Grid 33 instead of 34
KoolADE85 Jul 10, 2025
df6cd45
code cleanup
KoolADE85 Jul 10, 2025
e47d529
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 Jul 10, 2025
02ddf77
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 Jul 10, 2025
b2b9f55
code cleanup
KoolADE85 Jul 10, 2025
2cd615f
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 Jul 14, 2025
813f024
Merge branch 'main' into feature/ag-grid-33
KoolADE85 Jul 18, 2025
528ed11
Merge branch 'main' into feature/ag-grid-33
KoolADE85 Jul 18, 2025
317666e
Merge branch 'main' into feature/ag-grid-33
KoolADE85 Jul 18, 2025
8c67d20
Remove default & legacy theme code
KoolADE85 Jul 18, 2025
edee45d
Ensure compatibility between legacy themes and modern themes
KoolADE85 Jul 21, 2025
e604f0c
Lazy load css for legacy themes
KoolADE85 Jul 22, 2025
739b1b7
Lazy load css for legacy themes
KoolADE85 Jul 22, 2025
ff98be1
Revert "Lazy load css for legacy themes"
KoolADE85 Jul 22, 2025
70251dd
Revert "Lazy load css for legacy themes"
KoolADE85 Jul 22, 2025
f189f5d
Add a `themes` module for external stylesheet usage
KoolADE85 Jul 22, 2025
65dffdf
remove unnecessary files
KoolADE85 Jul 22, 2025
cdfff73
Add e2e test for legacy theme css
KoolADE85 Jul 23, 2025
6d908c0
Merge branch 'main' into feature/ag-grid-33
KoolADE85 Jul 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 104 additions & 54 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-ag-grid",
"version": "32.3.0rc0",
"version": "33.3.2rc0",
"description": "Dash wrapper around AG Grid, the best interactive data grid for the web.",
"repository": {
"type": "git",
Expand Down Expand Up @@ -32,11 +32,11 @@
"dependencies": {
"@emotion/react": "^11.11.3",
"@emotion/styled": "^11.11.0",
"ag-grid-community": "32.3.4",
"ag-grid-enterprise": "32.3.4",
"ag-grid-react": "32.3.4",
"@mui/icons-material": "^5.15.7",
"@mui/material": "^5.15.7",
"ag-grid-community": "33.3.2",
"ag-grid-enterprise": "33.3.2",
"ag-grid-react": "33.3.2",
"d3-format": "^3.1.0",
"d3-time": "^3.1.0",
"d3-time-format": "^4.1.0",
Expand Down
11 changes: 11 additions & 0 deletions src/lib/components/AgGrid.react.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
import PropTypes from 'prop-types';
import LazyLoader from '../LazyLoader';
import React, {lazy, Suspense, useState, useCallback, useEffect} from 'react';
import {
AllCommunityModule,
ModuleRegistry,
provideGlobalGridOptions,
} from 'ag-grid-community';

// Register all community features
ModuleRegistry.registerModules([AllCommunityModule]);

// Mark all grids as using legacy themes
provideGlobalGridOptions({theme: 'legacy'});
Comment thread
BSd3v marked this conversation as resolved.
Outdated

const RealAgGrid = lazy(LazyLoader.agGrid);
const RealAgGridEnterprise = lazy(LazyLoader.agGridEnterprise);
Expand Down
14 changes: 13 additions & 1 deletion src/lib/fragments/AgGridEnterprise.react.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
import React from 'react';
import {LicenseManager} from 'ag-grid-enterprise';
import {ModuleRegistry} from 'ag-grid-community';
import {
AllEnterpriseModule,
LicenseManager,
SparklinesModule,
} from 'ag-grid-enterprise';
import {AgChartsEnterpriseModule} from 'ag-charts-enterprise';
import MemoizedAgGrid, {propTypes} from './AgGrid.react';

// Register all enterprise features
ModuleRegistry.registerModules([
AllEnterpriseModule,
SparklinesModule.with(AgChartsEnterpriseModule),
]);

export default function DashAgGridEnterprise(props) {
const {licenseKey} = props;
if (licenseKey) {
Expand Down
7 changes: 6 additions & 1 deletion tests/test_cell_value_changed.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ def test_cv001_cell_value_changed(dash_duo):
columnDefs=[{"field": "Key", "checkboxSelection": True}]
+ [{"field": i} for i in ["Column", "OldValue", "NewValue"]],
rowData=[],
dashGridOptions={
"rowSelection": {
"mode": 'singleRow'
},
}
),
],
style={"margin": 20},
Expand All @@ -50,7 +55,7 @@ def test_cv001_cell_value_changed(dash_duo):
data = changes[i];
reloadData = {...data.data};
reloadData[data.colId] = data.oldValue;
newData.push({Key: data.rowId, Column: data.colId, OldValue: data.oldValue,
newData.push({Key: data.rowId, Column: data.colId, OldValue: data.oldValue,
NewValue: data.value, reloadData});
}
return {'add': newData}
Expand Down
2 changes: 1 addition & 1 deletion tests/test_grid_apis.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def test_ga001_grid_apis(dash_duo):
app.clientside_callback(
"""function (n) {
if (n) {
dash_ag_grid.getApi('grid').setColumnVisible("price", false)
dash_ag_grid.getApi('grid').setColumnsVisible(["price"], false)
}
return dash_clientside.no_update
}""",
Expand Down