Modification to have sponsor pages on plone.org#242
Conversation
…ionSponsor objects
…ct whether to link directly to the sponsor page or to the website of the sponsor
stevepiercy
left a comment
There was a problem hiding this comment.
TBH, most of this is way over my head, but I trust you know what you're doing. Nonetheless, it might be a good idea to get someone who has better understanding of the changes to review this before merging.
Or YOLO! and push to testing and see what that looks before deploying to production.
|
Well the YOLO mode doesn't work here, I need at least a seconder to approve the PRs! 👯 |
|
I will merge this when I receive some input from sponsors to prepare some pages in testing first, before pushing to prod. |
|
I have some content, so deploying to testing and then to prod! |
|
@erral got link to take a look? Please share! |
|
you can click on any sponsor on Plone.org like this one https://plone.org/foundation/sponsorship/sponsors/eau-de-web |
|
Oh, yes, indeed, that's nice! Great work! |
|
@erral I checked them all, and only one is... strange. Interaktiv has two links on https://plone.org/foundation/sponsorship/sponsors.
I think the first link should go to https://plone.org/foundation/sponsorship/sponsors/interaktiv, yes? |
|
Yes, I may have missed to configure it properly |
|
I have just updated the block configuration (I added a checkbox to show the link to the item, and I did not enable it). |
|
Yup, it works now. Thank you! |
Fixes: #241
Added features: