fix(frontend): quote Claude resume commands#349
Open
herikwebb wants to merge 1 commit into
Open
Conversation
Route Claude session resume launches through the shared command builder and shell-quote the transcript-derived session id before writing the command to a terminal. This prevents malicious session metadata from breaking out of claude --resume and executing shell commands when a user resumes a listed session.
pjdoland
approved these changes
May 26, 2026
Collaborator
pjdoland
left a comment
pjdoland
left a comment
There was a problem hiding this comment.
LGTM! The quoting fix is clean and correct: shellSingleQuote on sessionId closes the injection vector, and the deduplication through buildResumeCommand removes the inline copy that was missing CWD quoting too. Test coverage is solid, including the explicit breakout payload.
One small thing: CI is failing on a Prettier formatting issue in tests/ts/utils.test.ts. Running jlpm prettier --write tests/ts/utils.test.ts should clear it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route Claude session resume launches through the shared command builder and shell-quote the transcript-derived session id before writing the command to a terminal. This prevents malicious session metadata from breaking out of claude --resume and executing shell commands when a user resumes a listed session.