fix(server): reject forged upload context paths#348
Open
herikwebb wants to merge 1 commit into
Open
Conversation
Require WebSocket upload attachments to resolve under the server upload root before image reads or Claude Code file mentions use the supplied path. This closes the forged isUpload attack path that let an authenticated client point chat context at arbitrary server-readable files outside the workspace.
pjdoland
approved these changes
May 26, 2026
Collaborator
pjdoland
left a comment
pjdoland
left a comment
There was a problem hiding this comment.
LGTM. The commonpath containment check is correct (component-based, not string-prefix), symlink resolution via realpath on both sides is the right approach, and the two-branch partition (isUpload -> upload root, else -> workspace root) closes the vector cleanly. Test updates are a nice pattern improvement.
pjdoland
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require WebSocket upload attachments to resolve under the server upload root before image reads or Claude Code file mentions use the supplied path. This closes the forged isUpload attack path that let an authenticated client point chat context at arbitrary server-readable files outside the workspace.