add error handling in conference get and list#230
Open
varshit97plivo wants to merge 1 commit intomasterfrom
Open
add error handling in conference get and list#230varshit97plivo wants to merge 1 commit intomasterfrom
varshit97plivo wants to merge 1 commit intomasterfrom
Conversation
Zebulan Stanphill (ZebulanStanphill)
suggested changes
Oct 19, 2021
Zebulan Stanphill (ZebulanStanphill)
left a comment
Zebulan Stanphill (ZebulanStanphill)
left a comment
There was a problem hiding this comment.
You should update the PHPDoc at line 49 to:
@throws PlivoRestException|PlivoValidationException
Comment on lines
+64
to
+66
| if($response->getThrownException() != null) { | ||
| throw $response->getThrownException(); | ||
| } |
There was a problem hiding this comment.
This would be shorter and more idiomatic:
Suggested change
| if($response->getThrownException() != null) { | |
| throw $response->getThrownException(); | |
| } | |
| if(!$response->ok()) { | |
| throw $response->getThrownException(); | |
| } |
Comment on lines
+87
to
+89
| if($response->getThrownException() != null) { | ||
| throw $response->getThrownException(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if($response->getThrownException() != null) { | |
| throw $response->getThrownException(); | |
| } | |
| if(!$response->ok()) { | |
| throw $response->getThrownException(); | |
| } |
Narayana Shanbhog Plivo (narayana-plivo)
requested changes
Nov 8, 2021
Contributor
Narayana Shanbhog Plivo (narayana-plivo)
left a comment
Narayana Shanbhog Plivo (narayana-plivo)
left a comment
There was a problem hiding this comment.
suggestions are valid.
Mohammed Huzaif Plivo (@huzaif-plivo) requesting to make review change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.