Fix @property name typos in RestClient PHPDoc#229
Open
Zebulan Stanphill (ZebulanStanphill) wants to merge 2 commits intoplivo:masterfrom
Open
Fix @property name typos in RestClient PHPDoc#229Zebulan Stanphill (ZebulanStanphill) wants to merge 2 commits intoplivo:masterfrom
Zebulan Stanphill (ZebulanStanphill) wants to merge 2 commits intoplivo:masterfrom
Conversation
Narayana Shanbhog Plivo (narayana-plivo)
approved these changes
Nov 8, 2021
Contributor
Narayana Shanbhog Plivo (narayana-plivo)
left a comment
Narayana Shanbhog Plivo (narayana-plivo)
left a comment
There was a problem hiding this comment.
LGTM
Contributor
|
Hello! can this be pushed and released any time soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHPDoc for the
RestClientclass had some typos in its@propertydeclarations, with several missing ansat the end and one using the wrong capitalization. For example,messageswas incorrectly listed asmessage, which was quite confusing for me when using my IDE's auto-completion and comparing against this project's official documentation.This PR fixes those issues.