Skip to content

Conversation

@ljunkie
Copy link
Member

@ljunkie ljunkie commented Nov 25, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new GitHub Actions workflow for creating "shadow releases" of the XELP branch. The workflow automatically calculates a modified version number (adding 100 to the major version), builds the project, and publishes it to a separate xelp/dist branch with an appropriate version tag.

  • Creates versioned shadow releases from the xelp/main branch
  • Automates version calculation with a unique naming scheme (major+100, with date and commit hash metadata)
  • Builds and commits the distribution files to a dedicated branch with version tagging

Copilot AI review requested due to automatic review settings November 25, 2025 06:35
@ljunkie ljunkie force-pushed the rob/xelp-dist-workflow branch from 16181fb to d82e04c Compare November 25, 2025 06:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings November 25, 2025 06:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/xelp_shadow_release.yml:1

  • Array splitting logic can fail silently. When IFS='.' read splits the version string on line 38, if the version has fewer than 3 parts, the PARTS array will have fewer elements. Accessing ${PARTS[1]} or ${PARTS[2]} on lines 44-45 won't fail in bash but will result in empty strings, bypassing the check on line 39. This check should be performed immediately after the split, or use safer array access patterns. Move the validation block (lines 39-42) immediately after line 38, before any variable assignments.
name: Xelp Shadow Release

@ljunkie ljunkie enabled auto-merge (rebase) November 25, 2025 06:52
@ljunkie ljunkie disabled auto-merge November 25, 2025 06:52
@ljunkie ljunkie merged commit e20a1ed into xelp/main Nov 25, 2025
7 checks passed
@ljunkie ljunkie deleted the rob/xelp-dist-workflow branch November 25, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants