fix: renovate not updating node instrumentation Dockerfile#3189
Merged
fix: renovate not updating node instrumentation Dockerfile#3189
Conversation
Owner
|
Hello, thanks for contributing for the first time! |
…mentation Dockerfile Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix renovate not updating Dockerfile for node instrumentation
fix: renovate not updating node instrumentation Dockerfile
Mar 17, 2026
plengauer
approved these changes
Mar 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Renovate configuration so it continues to update the dummy Node instrumentation Dockerfile tag even when the latest Node major is an odd-numbered “Current” release (treated as unstable by default), ensuring CI can derive the correct upper bound Node version for building Node modules.
Changes:
- Add a Renovate
packageRulefor thedockerfilemanager targeting thenodeimage withignoreUnstable: false.
moflwi
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's built-in
workaroundspreset (part ofconfig:recommended) appliesnodeversioning to the officialnodeDocker image. With the defaultignoreUnstable: true, odd-numbered Node.js majors (Current releases like 25) are treated as unstable and skipped. Since Node 26 doesn't exist yet,FROM node:24sees no viable update → no PR, no log output.This matters because
build.ymlreads the Dockerfile version as the upper bound for which Node.js versions to build modules for:Changes
.github/renovate.json: AddpackageRulescoped to thedockerfilemanager for thenodeimage withignoreUnstable: false, consistent with the existing equivalent rule for Python OpenTelemetry packagesOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.