Skip to content

fix: renovate not updating node instrumentation Dockerfile#3189

Merged
plengauer merged 2 commits intomainfrom
copilot/fix-renovate-dockerfile-update
Mar 19, 2026
Merged

fix: renovate not updating node instrumentation Dockerfile#3189
plengauer merged 2 commits intomainfrom
copilot/fix-renovate-dockerfile-update

Conversation

Copy link
Contributor

Copilot AI commented Mar 17, 2026

Renovate's built-in workarounds preset (part of config:recommended) applies node versioning to the official node Docker image. With the default ignoreUnstable: true, odd-numbered Node.js majors (Current releases like 25) are treated as unstable and skipped. Since Node 26 doesn't exist yet, FROM node:24 sees no viable update → no PR, no log output.

This matters because build.yml reads the Dockerfile version as the upper bound for which Node.js versions to build modules for:

seq "$(min_version_from_packages)" \
    "$(grep '^FROM ' Dockerfile | cut -d: -f2)"

Changes

  • .github/renovate.json: Add packageRule scoped to the dockerfile manager for the node image with ignoreUnstable: false, consistent with the existing equivalent rule for Python OpenTelemetry packages
Original prompt

the dockerfile in the node instrumentation is not updated by renovate. the dockerfile is only used for that purpose. we never build an image from it, but we use it to have renovate update the version so we know what's the latest node version is. however renovate doesn't update it. the logs say nothing. tell me why and fix it


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@plengauer
Copy link
Owner

Hello, thanks for contributing for the first time!

…mentation Dockerfile

Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix renovate not updating Dockerfile for node instrumentation fix: renovate not updating node instrumentation Dockerfile Mar 17, 2026
Copilot AI requested a review from plengauer March 17, 2026 23:55
@plengauer plengauer marked this pull request as ready for review March 18, 2026 07:07
@plengauer plengauer requested a review from moflwi as a code owner March 18, 2026 07:07
Copilot AI review requested due to automatic review settings March 18, 2026 07:07
@plengauer plengauer enabled auto-merge (squash) March 18, 2026 07:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Renovate configuration so it continues to update the dummy Node instrumentation Dockerfile tag even when the latest Node major is an odd-numbered “Current” release (treated as unstable by default), ensuring CI can derive the correct upper bound Node version for building Node modules.

Changes:

  • Add a Renovate packageRule for the dockerfile manager targeting the node image with ignoreUnstable: false.

@plengauer plengauer merged commit 890166a into main Mar 19, 2026
572 of 573 checks passed
@plengauer plengauer deleted the copilot/fix-renovate-dockerfile-update branch March 19, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants