Skip to content

Fix json parsing with escapted characters producing corrupted jsons #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plengauer merged 2 commits into from
Mar 19, 2026
Merged

Fix json parsing with escapted characters producing corrupted jsons #3158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34ecb13
Clean up temporary stdout file in curl instrumentation
plengauer Mar 10, 2026
96abfee
Update src/usr/share/opentelemetry_shell/agent.instrumentation.curl.sh
plengauer Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/usr/share/opentelemetry_shell/agent.instrumentation.curl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,9 @@ _otel_curl_record_api_response_llm_openai() {
\[ "$frequency_penalty" = null ] || otel_span_attribute_typed "$span_handle" float gen_ai.request.frequency_penalty="$frequency_penalty"
\[ "$presence_penalty" = null ] || otel_span_attribute_typed "$span_handle" float gen_ai.request.presence_penalty="$presence_penalty"
done
\jq '[ .object // "null", .id // "null", .model // "null", .system_fingerprint // "null", .service_tier // "null", .temperature // "null", .top_k // "null", .top_p // "null", .frequency_penalty // "null", .presence_penalty // "null", .usage.prompt_tokens // .usage.input_tokens // "null", .usage.completion_tokens // .usage.output_tokens // "null", ( . | tostring ) ] | @tsv' -c -r --unbuffered | while IFS="$(\printf '\t')" read -r object id model system_fingerprint service_tier temperature top_k top_p frequency_penalty presence_penalty prompt_tokens completion_tokens json; do
local stdout="$(\mktemp -p "$_otel_shell_pipe_dir" opentelemetry_shell_$$.api.request.curl.pipe.XXXXXXXXXX)"
\cat "$stdout" &
\tee "$stdout" | \jq '[ .object // "null", .id // "null", .model // "null", .system_fingerprint // "null", .service_tier // "null", .temperature // "null", .top_k // "null", .top_p // "null", .frequency_penalty // "null", .presence_penalty // "null", .usage.prompt_tokens // .usage.input_tokens // "null", .usage.completion_tokens // .usage.output_tokens // "null" ] | @tsv' -c -r --unbuffered | while IFS="$(\printf '\t')" read -r object id model system_fingerprint service_tier temperature top_k top_p frequency_penalty presence_penalty prompt_tokens completion_tokens; do
case "$object" in
'response'|'response.chunk')
local operation_name=chat
Expand Down Expand Up @@ -352,8 +354,8 @@ _otel_curl_record_api_response_llm_openai() {
\[ "$model" = null ] || otel_observation_attribute_typed "$observation_handle" string gen_ai.response.model="$model"
otel_counter_observe "$gen_ai_client_operation_duration_handle" "$observation_handle"
fi
\printf '%s\n' "$json"
done
\rm -rf "$stdout"
Comment thread
plengauer marked this conversation as resolved.
: > "$api_recording_finished"
}

Expand Down
Loading