Fix PHP 8.4 deprecations and add some typing#8
Merged
migo315 merged 1 commit intoplayox:masterfrom Feb 7, 2025
Merged
Conversation
|
Great work. Thank you very much :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We're getting a
Deprecated: Flagception\Manager\FeatureManager::__construct(): Implicitly marking parameter $decorator as nullable is deprecated, the explicit nullable type must be used instead in vendor/flagception/flagception/src/Manager/FeatureManager.php on line 37deprecation message.This is due to the
public function __construct(FeatureActivatorInterface $activator, ContextDecoratorInterface $decorator = null)inmaster/src/Manager/FeatureManager.phpnot being PHP 8.4 compatible. More info about this deprecation: https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecatedThis pull request should fix this. I also added some extra typing. A pull request for the Symfony flagception bundle repository follows momentarily.