Allow quoted descriptions in schema definitions#46
Open
luisjakon wants to merge 2 commits intoplaylyfe:masterfrom
Open
Allow quoted descriptions in schema definitions#46luisjakon wants to merge 2 commits intoplaylyfe:masterfrom
luisjakon wants to merge 2 commits intoplaylyfe:masterfrom
Conversation
Member
|
Hi Luis, can you also add some tests to your PRs? |
Contributor
Author
|
Hi Kumar, I added a simple test to show it works fine with single-quoted descriptions without disrupting the hashmarked comments. It would be great if you or someone could take a look at the lexer/parser code to see how to best fit triple-quoted multi-line string parsing/decoding... Many thnxs! |
Contributor
Author
|
May be superseded by #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick fix for #45
Allows single-quoted descriptions in schema. Still missing triple-quoted multi-line descriptions...