Conversation
# Conflicts: # pnpm-lock.yaml # tsup.config.ts
|
/canary |
|
/canary |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| protected fun releaseRuntime() { | ||
| runBlocking { runtime.scope.coroutineContext[Job]?.children?.forEach { it.join() } } | ||
| runtime.release() | ||
| } |
There was a problem hiding this comment.
Nit: name this so it's clear what we're doing when we call it, releaseWhenIdle maybe?
| tsup_config(name = "tsup_config") | ||
| tsup_config( | ||
| name = "tsup_config", | ||
| native_bundle = NATIVE_BUNDLE, |
There was a problem hiding this comment.
This plugin also has a dependency on the beacon plugin, which means it'll have it's own copy too. Possible to configure this to accept some extra externals? Or should we just auto-populate the native TSUP config to resolve all workspace packages?
There was a problem hiding this comment.
Is Beacon's presence here as "given" as Player is for other plugins?
|
Add some release notes and/or update the PR title to describe the resulting change/impact. I've got a feeling this could cause some issues for consumers. If we're changing bundling strategy too, we should update our docs to say why things are external or change the template. We should really just refactor module loading in general to be a bit more standardized |
Do we want to consider this as part of 1.0 or post 1.0 if it could be breaking? |
Not necessarily, as long as we test in a few different places (like in any internal test framework). Just want the changelog to clearly reflect what changed in case we need to understand what happened when releasing this. |
5 participants
Currently, the plugin native bundles contain an entire copy of Player - this PR externalizes the Player from the native bundles, reducing size burden of the native bundles. Native plugins now need core player bundle to be loaded before in order to use.
This also makes the change to iOS HeadlessPlayer to load core Player right away, before any plugin instantiation.
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorN/ADoes your PR have any documentation updates?
📦 Published PR as canary version:
0.15.3--canary.836.34893Try this version out locally by upgrading relevant packages to 0.15.3--canary.836.34893