Skip to content

add render-time and async node error recovery pattern #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmarmer merged 50 commits into from
Apr 16, 2026

remove encodable from HookWithResult generic

9711da3
Select commit
Loading
Failed to load commit list.
Merged

add render-time and async node error recovery pattern #802

remove encodable from HookWithResult generic
9711da3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 15, 2026 in 0s

86.30% (+0.28%) compared to 07bcf2a

View this Pull Request on Codecov

86.30% (+0.28%) compared to 07bcf2a

Details

Codecov Report

❌ Patch coverage is 92.91498% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.30%. Comparing base (07bcf2a) to head (9711da3).

Files with missing lines Patch % Lines
.../core/Tests/utilities/JSValueExtensionsTests.swift 84.61% 8 Missing ⚠️
ios/core/Tests/ErrorControllerTests.swift 92.04% 7 Missing ⚠️
plugins/async-node/core/src/index.ts 95.39% 7 Missing ⚠️
...com/intuit/playerui/j2v8/extensions/HandleValue.kt 73.68% 1 Missing and 4 partials ⚠️
core/player/src/view/resolver/index.ts 93.65% 4 Missing ⚠️
...os/core/Sources/utilities/JSValue+Extensions.swift 90.00% 4 Missing ⚠️
...e/serialization/serializers/ThrowableSerializer.kt 89.47% 3 Missing and 1 partial ⚠️
react/player/src/player.tsx 95.69% 4 Missing ⚠️
ios/core/Tests/Types/HooksTests.swift 84.21% 3 Missing ⚠️
.../com/intuit/playerui/core/error/ErrorController.kt 72.72% 0 Missing and 3 partials ⚠️
... and 13 more
Additional details and impacted files 
@@                 Coverage Diff                  @@
##           error-controller     #802      +/-   ##
====================================================
+ Coverage             86.02%   86.30%   +0.28%     
====================================================
  Files                   513      514       +1     
  Lines                 23566    24013     +447     
  Branches               2703     2824     +121     
====================================================
+ Hits                  20272    20725     +453     
- Misses                 2956     2959       +3     
+ Partials                338      329       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov