Implement Node and NodeManager with full hierarchy management#19
Open
diogon01 wants to merge 1 commit intoplathanus-tech:masterfrom
Open
Implement Node and NodeManager with full hierarchy management#19diogon01 wants to merge 1 commit intoplathanus-tech:masterfrom
diogon01 wants to merge 1 commit intoplathanus-tech:masterfrom
Conversation
diogon01
commented
Sep 25, 2025
diogon01
commented
- Node class with id and parent, type hints, repr, eq, and hash.
- NodeManager class supporting single removal and recursive cascade removal.
- Robust input validation and immutability of the input node list.
- Optimized DFS for remove_cascade ensuring O(n) complexity for hierarchical operations.
- Code follows PEP8, type hints, and senior-level best practices.
- All pytest tests pass.
- Node class with id and parent, type hints, __repr__, __eq__, and __hash__. - NodeManager class supporting single removal and recursive cascade removal. - Robust input validation and immutability of the input node list. - Optimized DFS for remove_cascade ensuring O(n) complexity for hierarchical operations. - Code follows PEP8, type hints, and senior-level best practices. - All pytest tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.