Open
Conversation
Author
|
Test results from local: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on changes in platformatic/platformatic#4688
This allows watt-extra to use the same logging configuration as the watt application that it is running.
One potential gap: when calling the
versioncommand, it won't know about the app dir. I think this is ok because:startcommand prints the version and has the context of where the watt.json is located, correctly formatting the logsRunning from root of this project:
Running against a fixture with
debuglevel and ISO timestamp:To test locally:
feat/cli-logger-extensionbranch from platformatic