feat: generate flamegraphs on demand#122
Draft
ivan-tymoshenko wants to merge 12 commits intomainfrom
Draft
Conversation
Qard
approved these changes
Nov 27, 2025
Member
Qard
left a comment
There was a problem hiding this comment.
Minor suggestion, but otherwise LGTM.
| await profiler.requestProfile({ alertId: 'test-alert' }) | ||
|
|
||
| // Wait for profile to be generated (duration is 1 second) | ||
| await sleep(1500) |
Member
There was a problem hiding this comment.
Rather than using plain await sleep(...) all over the place, delaying test completions longer than may actually be necessary, we might want to use a Promise.race(...) pattern for waiting on a completion condition with a timeout for failure. Something like:
await Promise.race([
sleep(1500).then(() => Promise.reject('timeout')),
profileReceivedPromise
])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the flamegraphs plugin from an always-on profiling model to an on-demand architecture. Instead of continuously profiling all workers at fixed intervals, profiling now starts only when explicitly
requested (via alerts, health signals, or WebSocket commands) and automatically stops when idle.
Previously, workers were profiled continuously and the eluThreshold setting determined whether profiles should be captured based on Event Loop Utilization. With on-demand profiling, the ELU threshold logic has been
removed entirely—profiles are now generated whenever requested, regardless of current utilization metrics. This gives callers explicit control over when profiling occurs rather than relying on automatic threshold-based
triggering.
Multiple profile requests are queued and associated with generated profiles based on timestamps. Profilers automatically stop after an idle period if no new requests arrive, preventing unnecessary resource consumption.