Conversation
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
| const PlatformaticServiceSchema = Type.Union([ | ||
| PlatformaticServiceWithImageSchema, | ||
| PlatformaticServiceWithLocalSchema | ||
| ]) | ||
|
|
There was a problem hiding this comment.
So the reason for this Union is that, in my opinion, it is confusing to say:
- I want hot reload on this repository
- but also use this image
This was one of the complaints from cib in knowing what was building
There was a problem hiding this comment.
OK, but now desk knows because we use explicit profiles, right?
So, being this a schema definition, it should just support all cases, or am I missing something?
There was a problem hiding this comment.
I brought it up because showing the image details and the local repository details in the same profile are confusing.
There was a problem hiding this comment.
Correct, having the image is useless and confusing. Removed.
docker/machinist/Dockerfile.dev
Outdated
| # are compiled for the host OS and won't work in Alpine Linux | ||
| # 4. .env files from the host might have localhost connection strings that would override | ||
| # the Kubernetes environment variables | ||
| CMD sh -c 'find . -name ".env" -type f -delete && rm -rf node_modules && pnpm install && pnpm run dev' |
There was a problem hiding this comment.
One of the pitfalls we hit with cib is that the delete command would remove the .env from the project. This is why it did a mv .env .backup-env when starting and mv .backup-env .env when shutting down.
There was a problem hiding this comment.
@marcopiraccini I know I left a lot of comments so this may have been missed: keeping the delete means that if someone were to run icc by itself, they would need to recreate their .env file every time.
There was a problem hiding this comment.
It's already a mv: https://github.com/platformatic/desk/blob/dev-prof-2/docker/Dockerfile.dev#L21
CMD sh -c 'find . -name ".env" -type f -exec mv {} {}.backup-env \; && rm -rf node_modules && pnpm install && pnpm run dev'
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
changed the title
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: Leonardo Rossi <leonardo.rossi@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
3 participants
We need this to test it: platformatic/helm#49
Fixes: