#731 :: [UI] add prompts for missing VDDK, credentials #1372
Merged
sarika-pf9 merged 7 commits intomainfrom Jan 22, 2026
Merged
#731 :: [UI] add prompts for missing VDDK, credentials #1372sarika-pf9 merged 7 commits intomainfrom
sarika-pf9 merged 7 commits intomainfrom
Conversation
…, here's an appropriate commit message: ``` Added react-joyride package and updated peer dependencies ``` This commit message follows the repository's style of being concise and descriptive. The changes show: - Addition of `react-joyride` package (version ^2.9.3) to dependencies - Multiple packages marked as peer dependencies - Addition of various esbuild platform-specific packages The message captures the main functional change
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (3)
- ui/src/features/onboarding/components/GettingStartedDialog.tsx (66-76) The Dialog can currently be closed by clicking outside or pressing ESC. For important onboarding steps, consider adding `disableEscapeKeyDown={true}` and handling backdrop clicks explicitly to ensure users don't accidentally dismiss important setup instructions.
- ui/src/features/globalSettings/components/GlobalSettingsPage.tsx (763-769) The useEffect dependency array includes `activeTab`, which could cause the effect to run again after `setActiveTab(requestedTab)` is called. This might lead to unnecessary re-renders. Consider removing `activeTab` from the dependency array since you're already checking `if (requestedTab === activeTab) return` inside the effect.
- ui/src/features/globalSettings/components/VDDKUploadTab.tsx (17-17) The `existingVddkMessage` prop is defined but only used in commented out code. Either remove the unused prop or uncomment the code that uses it.
1 file skipped due to size limits:
- ui/package-lock.json
💡 To request another review, post a new comment with "/windsurf-review".
…and DOM observation scoping Consolidated guide mode logic into a unified configuration object, replaced direct path checks with config-based navigation, and scoped MutationObserver to AppContent ref instead of document.body for better performance and targeted DOM monitoring.
sarika-pf9
approved these changes
Jan 22, 2026
sarika-pf9
deleted the
731-ui-add-prompts-for-missing-vddk-credentials
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
fixes #
Testing done
new
Screencast from 21-01-26 03:48:01 PM IST.webm
old
Screencast from 14-01-26 06:12:34 PM IST.webm