Skip to content

Fix Lint: allow lowercase and special chars in REQUEST_METHOD #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kimjune01 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix Lint: allow lowercase and special chars in REQUEST_METHOD #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Plack/Middleware/Lint.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ sub validate_env {
unless ($env->{REQUEST_METHOD}) {
die('Missing env param: REQUEST_METHOD');
}
unless ($env->{REQUEST_METHOD} =~ /^[A-Z]+$/) {
unless ($env->{REQUEST_METHOD} =~ /^[A-Za-z0-9!#\$%&'*+\-.^_`|~]+$/) {
die("Invalid env param: REQUEST_METHOD($env->{REQUEST_METHOD})");
}
unless (defined($env->{SCRIPT_NAME})) { # allows empty string
Expand Down
6 changes: 5 additions & 1 deletion t/Plack-Middleware/lint_env.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,15 @@ $app = Plack::Middleware::Lint->wrap($app);

my @good_env = (
{ PATH_INFO => '' },
{ REQUEST_METHOD => 'get' },
{ REQUEST_METHOD => 'GeT' },
{ REQUEST_METHOD => 'my-custom-method' },
);

my @bad_env = (
[ { REQUEST_METHOD => undef }, qr/Missing env param: REQUEST_METHOD/ ],
[ { REQUEST_METHOD => "foo" },, qr/Invalid env param: REQUEST_METHOD/ ],
[ { REQUEST_METHOD => "foo bar" }, qr/Invalid env param: REQUEST_METHOD/ ],
[ { REQUEST_METHOD => "" }, qr/Missing env param: REQUEST_METHOD/ ],
[ { PATH_INFO => 'foo' }, qr/PATH_INFO must begin with \// ],
[ { SERVER_PORT => undef }, qr/Missing mandatory .*SERVER_PORT/ ],
[ { SERVER_PROTOCOL => 'HTTP/x' }, qr/Invalid SERVER_PROTOCOL/ ],
Expand Down