Upgrade Detekt from 1.23.8 to 2.0.0-alpha.2#69
Open
MariusVolkhart wants to merge 1 commit intomainfrom
Open
Conversation
Detekt 2.0 changed its Maven coordinates from io.gitlab.arturbosch.detekt
to dev.detekt, migrated from K1 (BindingContext/descriptors) to the K2
Kotlin Analysis API, and made several API breaking changes.
Build changes:
- All detekt artifact coordinates updated to dev.detekt group
- Added detekt-psi-utils dependency (FunctionMatcher moved there from tooling)
- Detekt Gradle task properties migrated to lazy API: parallel.set(), jvmTarget.set(), buildUponDefaultConfig.set()
- Plugin IDs updated from io.gitlab.arturbosch.detekt to dev.detekt
Source changes:
- EnforceStaticImport: migrated from visitCallExpression + BindingContext to
visitDotQualifiedExpression + analyze { resolveToCall().singleFunctionCallOrNull() }
using the K2 Analysis API; Rule now takes description in constructor instead of
an issue property; CodeSmell replaced by Finding
- ImportExtensionProvider: instance() no longer takes Config; ruleSetId is now
RuleSetId type; RuleSet now takes Map<RuleName, (Config) -> Rule> not List<Rule>
- ImportConfigValidator: Notification changed from interface to final class;
added required id property from Extension interface
- EnforceStaticImportTest: migrated to KotlinEnvironmentContainer / lintWithContext;
external library tests replaced with JDK equivalents since the new test engine
only includes JDK, stdlib, and coroutines in the analysis session
Config changes (detekt.yml):
- ForbiddenImport: imports -> forbiddenImports, removed forbiddenPatterns
- RedundantVisibilityModifierRule -> RedundantVisibilityModifier
- SpacingBetweenPackageAndImports -> SpacingAfterPackageDeclaration
- UntilInsteadOfRangeTo -> RangeUntilInsteadOfRangeTo
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
MariusVolkhart
requested review from
ethan-wrasman-pkware and
mbayerPK
as code owners
Collaborator
|
Whats the reasoning behind upgrading to an alpha version of detekt here? |
Member
Author
The 1.x line of Detekt isn't fully Compatible with Kotlin 2.x, and we're beginning to encounter incorrect analysis internally. The Detekt 2.x Alpha line is the best thing available right now. But also, "alpha" is a loose term here. It's a linter with a long history - it's not going to suddenly take down production or something. |
mbayerPK
approved these changes
Apr 9, 2026
| val code = """ | ||
| fun main() { | ||
| val value = 3.3 | ||
| var value = 3.3 |
Collaborator
There was a problem hiding this comment.
This should still be val as its not re-set
| val code = """ | ||
| import com.google.common.truth.Truth | ||
| import com.google.common.truth.Truth.assertThat | ||
| import org.junit.jupiter.params.provider.Arguments |
Collaborator
There was a problem hiding this comment.
Not sure why it claude elected to change the imports used on this test since the old ones made it explicit as what was being tested and the new one(s) are less clear- especially with java.time.LocalDate.now not having an import declaration
| val code = """ | ||
| fun main() { | ||
| value = 3.7 | ||
| var value = 3.7 |
| val code = """ | ||
| fun main() { | ||
| value = 3.7 | ||
| var value = 3.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detekt 2.0 changed its Maven coordinates from io.gitlab.arturbosch.detekt to dev.detekt, migrated from K1 (BindingContext/descriptors) to the K2 Kotlin Analysis API, and made several API breaking changes.
Build changes:
Source changes:
Config changes (detekt.yml):