Overhaul Makefile build process #150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the Makefile build system in wxLua with one which doesn't make use of recursive make and allows for more flexibility when selecting the wxWidgets/Lua libraries to build/link against. The end goal of this work is to make it so that portions of wxLua can be compiled into other Make-based projects by including the Makefile and simply depending on the appropriate targets. The C++ #include directives are reworked so that relative include paths are *actually* relative (where appropriate) rather than depending on the compiler include path including practically every directory in the wxLua source tree. The public headers have been moved to a dedicated include directory.
This commit removes all of the pre-build bindings from the source tree and properly integrates them into the Makefile so they can be build as dependencies of the targets that need them.
Set the WXLUA_ROOT variable before including to allow building from another directory. The 'all' and 'clean' targets have been renamed to 'wxlua-all' and 'wxlua-clean' to avoid conflict with other project(s). A wrapper target for 'clean' is defined only when WXLUA_ROOT is unset.
Outputs from genwxbind.lua are always overwritten now so that their modification timestamp accurately reflects when they were updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big (and potentially contentious) change, but I've reworked the Makefiles for wxLua with the following goals:
In addition to the above, I made the following changes while refactoring:
wxluasetup.htowxluasetup-defaults.hwhich can be included from a userwxluasetup.h