Handle special characters in project paths in analyzeall.lua#89
Open
iamevn wants to merge 3 commits intopkulchenko:masterfrom
Open
Handle special characters in project paths in analyzeall.lua#89iamevn wants to merge 3 commits intopkulchenko:masterfrom
iamevn wants to merge 3 commits intopkulchenko:masterfrom
Conversation
I was having issues getting the ignore list working on windows. Figured out it had to do with gsub expecting a pattern instead of a literal string.
Owner
|
@iamevn, thank you for the patch! Do you have a specific example it was previously failing on? |
Author
|
Huh, was having trouble reproducing initially and it actually seems to be some problem with "-" in the project path? Here's a gist with both the current |
Owner
|
It may be related to the fact that |
Author
|
Looking over this again I think the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having issues getting the ignore list working on Windows.
Figured out it had to do with gsub expecting a pattern instead of a literal string and the
\\characters in windows paths probably tripping it up.filePath:gsub(projectPath, "")would not find any matches andcheckPathwould contain the full path to the file instead of a path rooted at the projectPath. Using a pattern similar to the masks gets the gsub working.