Accept '-' in usernames for ls self-test#639
Merged
puellanivis merged 1 commit intopkg:masterfrom Oct 22, 2025
Merged
Conversation
puellanivis
reviewed
Oct 7, 2025
ls_formatting_test.go
Outdated
| // username / uid (len 8, number or string) | ||
| const ( | ||
| name = "(?:[a-z_][a-z0-9_]*)" | ||
| name = "(?:[a-z_][-a-z0-9_]*)" |
Collaborator
There was a problem hiding this comment.
If we’re going to be expanding this username regexp, then we should probably target adding all the allowed characters (that is, underscore and period) and upper-case letters.
Contributor
Author
There was a problem hiding this comment.
I updated the pull request to include those in the regexp too, thanks!
c4f1526 to
935fe8e
Compare
puellanivis
added a commit
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! We got this test failure because
-is not accepted in usernames by the code, this pull request fixes this.Thanks,
Simon