Add pjmedia_ice_parse_cand#4729
Merged
sauwming merged 1 commit intopjsip:masterfrom Jan 9, 2026
Merged
Conversation
sauwming
reviewed
Jan 8, 2026
saghul
force-pushed
the
parse-cand
branch
2 times, most recently
from
303403a to
6e84f63
Compare
Contributor
Author
|
@sauwming Done! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes a previously internal function for parsing ICE candidate strings as a public API, enabling PJMEDIA to parse WebRTC-style candidate lines when used without SIP.
Key changes:
- Converts the static
parse_candfunction into the publicpjmedia_ice_parse_candAPI - Refactors parameter handling to remove the unused
obj_nameparameter and generate it internally - Updates all internal call sites to use the new function signature
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pjmedia/include/pjmedia/transport_ice.h | Adds public API declaration and documentation for pjmedia_ice_parse_cand |
| pjmedia/src/pjmedia/transport_ice.c | Moves parse_cand from private static function to public API, removes forward declaration, and updates 3 call sites to use the new signature |
When PJMEDIA is used without SIP it's useful to be able to parse candidate lines if they follow the same format as SDP. An example of this is parsing candidates coming from WebRTC events.
Contributor
Author
|
Updated again! |
nanangizz
approved these changes
Jan 9, 2026
sauwming
approved these changes
Jan 9, 2026
Contributor
Author
|
Thanks guys! |
wosrediinanatour
pushed a commit
to wosrediinanatour/pjproject
that referenced
this pull request
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PJMEDIA is used without SIP it's useful to be able to parse
candidate lines if they follow the same format as SDP. An example of
this is parsing candidates coming from WebRTC events.