Fixed incorrect projection#176
Open
stevenwithaph wants to merge 2 commits intopixijs-userland:mainfrom
Open
Conversation
|
@stevenwithaph thank you SO much for sharing this patch - essential bugfix that should be released ASAP, as the tilemap is extremely broken with parent containers without it! might also need to be applied to the webgpu pipe too. cc @bigtimebuddy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #167
I think the issue was the world transform being applied twice here. Removing
.append(u_global.uWorldTransformMatrix)seemed to fix it, thetilemap.worldTransformshould already contain theuWorldTransformMatrixI also added panning to the basic example to test this change. Can be removed.