Open
Conversation
- `text_sizes` is assigned in constructor so doesn't need null assignment - `tex_buf` is also assigned in constructor - `bind_group` has null check in `getBindGroup()` - added `| null` to `bind_group` to accurately reflect typing
Breaking Change: - changed return type of `getShader()` - `indexBuffer` can be made readonly and type kept as it's assigned in constructor - added `| null` to `shader`
- adjusts typing to reflect assigned types
- doesn't change the initial values of any of the variables - adds `| null` where `null` was assigned - adds `null` checks ^ would want opinion in review if position of these checks makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using your library at work and decided to poke around :)
Figured fixing some TODOs is a nice way to start contributing.
I've adjusted the variable types to more accurately reflect the value they were assigned.
There is some breaking changes where I've adjusted the types on public variables.
I've also added some early returns and null checks which could change behavior. Feel free to let me know if any of them don't make sense or are in the wrong place.