Add no-humanize and remove root verification#25
Open
pik wants to merge 2 commits intopixelb:masterfrom
Open
Conversation
Owner
|
Re getting totals for further processing, does the filtering + --total option handle your use case? |
Author
|
@pixelb Well this way you can get the share-mem / swap use included as well e.g. (also the number of processes if they are multiples) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
--no-humanizeflag to allow writing the ps_mem output in an easily machine parsable form (e.g. useful for later graphing the data in matplotlib).Also I believe the
rootuser verification is an artifact of some older code? As long as the process running is owned by the user ps_mem run by the user will have access to the appropriate proc files.On a side-note I'm quite curious as to the point of the
if pssbranch inprint_memory_usage-- here is the difference in output with the code present and with the code commented out:vs.
It's really hard for me to tell what the delimiter lines are adding here.. Perhaps the entire branch should be pruned?