feat: add hook to sorting selected options on open with enable flag#43
Open
pbuba wants to merge 3 commits into
Open
feat: add hook to sorting selected options on open with enable flag#43pbuba wants to merge 3 commits into
pbuba wants to merge 3 commits into
Conversation
pbuba
commented
Apr 30, 2025
pbuba
commented
- add hook to sorting selected options on open
- add sorting hook for multi-select component
- add enable flag
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3em
reviewed
May 2, 2025
| if (enable && isOpen) { | ||
| setSnapshotIds(new Set(selectedItems.map(item => item.id))) | ||
| } | ||
| }, [isOpen, enable]) |
There was a problem hiding this comment.
We can avoid using useEffect here — especially since selectedItems might not be updated at the right time.
You already have the onOpenChange event on DropdownMenu.Root.
3em
reviewed
May 2, 2025
3em
reviewed
May 2, 2025
| searchValue={searchTag} | ||
| handleChangeSearchValue={setSearchTag} | ||
| error={errors.tags?.message?.toString()} | ||
| enableSortOnOpen |
There was a problem hiding this comment.
Actually, this should be the default behavior, so we can remove this prop and always apply sorting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.