Fix bublikov task 1#42
Open
pbuba wants to merge 6 commits into
Open
Conversation
pbuba
commented
Apr 30, 2025
pbuba
commented
- move DelegateSelectorDrawer to packages/ui/src/views/
- Styled Drawer as figma (Text, layout, gap)
- Fix on top header and on bottom footer
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3em
reviewed
Apr 30, 2025
3em
reviewed
Apr 30, 2025
3em
reviewed
Apr 30, 2025
3em
reviewed
Apr 30, 2025
3em
reviewed
Apr 30, 2025
3em
reviewed
May 2, 2025
| primary ? 'text-3 leading-snug' : secondary ? 'text-2' : 'text-sm', | ||
| 'text-cn-foreground-1 [&>em]:text-cn-foreground-1 font-normal [&>em]:font-medium [&>em]:not-italic', | ||
| !!label && 'text-cn-foreground-2', | ||
| className |
There was a problem hiding this comment.
I know there was an issue with className here, but before removing it, we should check all usages of ListField across the projects
3em
reviewed
May 2, 2025
| className={cn( | ||
| '[&_tr:last-child]:border-0', | ||
| { '[&>tr:hover]:bg-cn-background-hover': hasHighlightOnHover }, | ||
| { '[&>tr:hover]:cursor-pointer': hasHighlightOnHover }, |
There was a problem hiding this comment.
This style shouldn’t be applied — hasHighlightOnHover doesn’t always imply a cursor change. It’s just for highlighting rows.
3em
reviewed
May 2, 2025
| description={option.description} | ||
| descriptionClassName={cn('leading-tight', { | ||
| 'text-cn-foreground-4': value !== option.value, | ||
| '': option.disabled |
3em
reviewed
May 2, 2025
| className={isLoading ? '[mask-image:linear-gradient(to_bottom,black_30%,transparent_100%)]' : ''} | ||
| variant="asStackedList" | ||
| > | ||
| <Table.Root className="table-auto" variant="asStackedList"> |
There was a problem hiding this comment.
We should use tableClassName="table-fixed" and remove all max-w-{{}} from Table.Cell
3em
reviewed
May 2, 2025
| return ( | ||
| <Table.Row key={groupId}> | ||
| <Table.Cell className="max-w-28 content-center !py-4"> | ||
| <div className="flex items-center gap-2.5"> |
3em
reviewed
May 2, 2025
| </Drawer.Header> | ||
|
|
||
| <Drawer.Inner> | ||
| <div className="px-6 pt-5 leading-[18px]"> |
There was a problem hiding this comment.
Better to avoid custom values — we can use leading-tight here instead
3em
reviewed
May 2, 2025
| <Drawer.Close className="sr-only" onClick={() => setOpen(false)} /> | ||
| </Drawer.Header> | ||
|
|
||
| <Drawer.Inner> |
There was a problem hiding this comment.
You can set default paddings in Drawer.Inner, so you don't need to apply padding to each child component individually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.