Skip to content

refactor: tabs navigation#21

Open
ankormoreankor wants to merge 2 commits into
mainfrom
tabs-navigation-refactoring
Open

refactor: tabs navigation#21
ankormoreankor wants to merge 2 commits into
mainfrom
tabs-navigation-refactoring

Conversation

@ankormoreankor

@ankormoreankor ankormoreankor commented Jan 30, 2025

Copy link
Copy Markdown

There was a bug in tabs: when switching between tabs with Tab button, you could go forward but get stuck when going backward. The issue is probably related to having links inside buttons in the Tabs component.

tabs.mp4
  • Moved tabs to the new TabNav component
  • Fixed the header height and the position of the tabs (55px -> 58px)

@vercel

vercel Bot commented Jan 30, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
canary ❌ Failed (Inspect) Mar 5, 2025 0:10am

@ankormoreankor ankormoreankor force-pushed the project-settings-review branch 3 times, most recently from 3d37b2e to 21037e8 Compare January 30, 2025 13:17
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 81bb55e to b776a24 Compare January 30, 2025 13:24
Comment thread packages/views/src/layouts/SandboxLayout.tsx Outdated
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 8f80806 to 1b714a3 Compare January 31, 2025 09:31
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 1b714a3 to 4572c28 Compare January 31, 2025 09:43
@iatopilskii iatopilskii force-pushed the project-settings-review branch from 21037e8 to e0f9328 Compare January 31, 2025 12:20
@ankormoreankor ankormoreankor changed the base branch from project-settings-review to main January 31, 2025 12:35
@ankormoreankor ankormoreankor changed the base branch from main to project-settings-review January 31, 2025 12:38
@ankormoreankor ankormoreankor changed the base branch from project-settings-review to main January 31, 2025 12:40
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 4572c28 to 9f92d1c Compare January 31, 2025 13:02
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 9f92d1c to a9be11c Compare January 31, 2025 13:08
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from a9be11c to faf1c0a Compare February 3, 2025 12:07
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from faf1c0a to 0eb786d Compare February 3, 2025 12:31
Comment thread apps/gitness/src/routes.tsx Outdated
Comment thread packages/ui/src/components/tabs.tsx
Comment thread packages/ui/src/components/tabnav.tsx Outdated
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 7672521 to c7162e5 Compare February 25, 2025 11:55
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 44e03b7 to a64ee34 Compare February 26, 2025 09:54
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from a64ee34 to dbf8136 Compare February 26, 2025 09:59
@ankormoreankor ankormoreankor requested a review from 3em February 26, 2025 10:07
@3em 3em force-pushed the tabs-navigation-refactoring branch from dbf8136 to 0243776 Compare February 27, 2025 07:21
@3em 3em force-pushed the tabs-navigation-refactoring branch from 0243776 to 12d4e23 Compare February 27, 2025 07:21
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 12d4e23 to c079212 Compare February 27, 2025 10:27
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from c079212 to 661994c Compare February 27, 2025 10:28
@3em 3em force-pushed the tabs-navigation-refactoring branch from 661994c to 18ceb1f Compare February 28, 2025 04:06
@ankormoreankor ankormoreankor force-pushed the tabs-navigation-refactoring branch from 18ceb1f to 1e8a600 Compare February 28, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants