refactor: expose tools, prompts, resources, argo via pkg/#170
Merged
Conversation
Promotes the four packages downstream MCP servers need to consume to pkg/, so they can be imported directly. server, config, and version remain in internal/ as binary-specific glue. API surface remains pre-v1 and volatile. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (33)
📒 Files selected for processing (117)
WalkthroughThis PR promotes the ChangesPackage Promotion: Internal to Public
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The changes are mechanically simple (import path redirects) and highly repetitive across ~100+ files, making individual file review quick. However, the sheer volume and interconnected nature of the refactoring across multiple packages and tests requires systematic verification to ensure no import cycles, broken references, or inconsistencies were introduced. The presence of both production code and test files doubling the scope adds moderate complexity. Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/{argo,tools,prompts,resources}topkg/so other MCP servers can import them. The four packages keep their existing public shape (tools.RegisterAll(s, client),prompts.RegisterAll,resources.RegisterAll,argo.ClientInterface).internal/{server,config,version}stay internal — they're binary-specific glue.pkg/resources/docs/*.mdcontinues to work via//go:embed, so downstream consumers ship the same Argo docs/examples.Makefiletest target,.golangci.yml,.coderabbit.yaml,CLAUDE.md,docs/RESOURCES.md, and the two.claude/agents/*.mdfiles to point at the new paths.Notes
git mv, so blame/history is preserved.Test plan
make allpasses (fmt, vet, lint 0 issues, tests across all packages, linux/amd64 build)pkg/argo51.6%,pkg/prompts65.4%,pkg/resources86.2%,pkg/tools91.9%,internal/server91.2% — all unchanged from before the movemake test-e2e) — not run locally; CI will exercise these🤖 Generated with Claude Code
Summary by CodeRabbit
pkg/directory, enabling external integration and reusability of core components.