Closed
Conversation
Signed-off-by: Alan Clucas <alan@clucas.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just for @isubasinghe.
I do not intend to end up with any tests except for the examples one.
None of this really works, but the unit test passes.
The idea I was working towards was to end up with the examples working, and then convert them into variables.md or upgrading.md notes.
The e2e test doesn't work, and is mostly a mess, but there for reference in case something is useful.
Note - existing
expr_lang.godoesn't end in _test, so never gets tested. Suggest a quick PR to rename it so it actually does something useful.The sprig sorted list in the root doesn't have the allowList entries removed from it, but should be all the functions that need testing.