feat: add support for make codegen/pre-commit through nix#31
Open
isubasinghe wants to merge 2 commits intopipekit:masterfrom
Open
feat: add support for make codegen/pre-commit through nix#31isubasinghe wants to merge 2 commits intopipekit:masterfrom
isubasinghe wants to merge 2 commits intopipekit:masterfrom
Conversation
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
isubasinghe
changed the title
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Collaborator
Author
|
@JPZ13 can you have a suss at this, should be trivial ? Can't assign you myself. |
Collaborator
|
@isubasinghe - pardon the permissions issue. You should now be a maintainer on the repo I'm also a little strapped for time at the moment. Could you get @Joibel or @rohankmr414 to test it out? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: You need to be inside a nix shell for this to work, use
nix developto get a shell.Adds support for
make codegen,make pre-commit -Bcommands via nix.To use nix supply the USE_NIX variable with
truewhen invoking make.For example
make USE_NIX=true pre-commit -B