Skip to content

Export GetCodecMap for efficient payload type lookups #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asnyatkov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Export GetCodecMap for efficient payload type lookups #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5014502
Export GetCodecMap for payload lookups
asnyatkov Mar 26, 2026
bad8576
Merge branch 'main' into feat/export-codec-map
asnyatkov May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,10 @@ func mergeCodecs(codec Codec, codecs map[uint8]Codec) {
codecs[savedCodec.PayloadType] = savedCodec
}

func (s *SessionDescription) buildCodecMap() map[uint8]Codec { //nolint:cyclop
// GetCodecMap parses the SessionDescription and returns a map of payload
// type to Codec. This allows callers to build the map once and look up
// multiple payload types without rebuilding it each time.
func (s *SessionDescription) GetCodecMap() map[uint8]Codec { //nolint:cyclop
codecs := map[uint8]Codec{
// static codecs that do not require a rtpmap
0: {
Expand Down Expand Up @@ -326,7 +329,7 @@ func codecsMatch(wanted, got Codec) bool {

// GetCodecForPayloadType scans the SessionDescription for the given payload type and returns the codec.
func (s *SessionDescription) GetCodecForPayloadType(payloadType uint8) (Codec, error) {
codecs := s.buildCodecMap()
codecs := s.GetCodecMap()

codec, ok := codecs[payloadType]
if ok {
Expand All @@ -337,7 +340,7 @@ func (s *SessionDescription) GetCodecForPayloadType(payloadType uint8) (Codec, e
}

func (s *SessionDescription) GetCodecsForPayloadTypes(payloadTypes []uint8) ([]Codec, error) {
codecs := s.buildCodecMap()
codecs := s.GetCodecMap()

result := make([]Codec, 0, len(payloadTypes))
for _, payloadType := range payloadTypes {
Expand All @@ -353,7 +356,7 @@ func (s *SessionDescription) GetCodecsForPayloadTypes(payloadTypes []uint8) ([]C
// GetPayloadTypeForCodec scans the SessionDescription for a codec that matches the provided codec
// as closely as possible and returns its payload type.
func (s *SessionDescription) GetPayloadTypeForCodec(wanted Codec) (uint8, error) {
codecs := s.buildCodecMap()
codecs := s.GetCodecMap()

for payloadType, codec := range codecs {
if codecsMatch(wanted, codec) {
Expand Down
2 changes: 1 addition & 1 deletion util_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ func TestBuildCodecMap_RtcpFbError(t *testing.T) {
},
}

codecs := sd.buildCodecMap()
codecs := sd.GetCodecMap()

// the three static codecs should be present, unchanged.
if assert.Len(t, codecs, 3) {
Expand Down
Loading