Skip to content

Conversation

@Juliapixel
Copy link
Member

@Juliapixel Juliapixel commented Dec 26, 2025

Still needs more tests
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 77.83934% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.43%. Comparing base (1f90ade) to head (3ac2fd4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
codecs/h266_packet.go 77.83% 46 Missing and 34 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   90.97%   89.43%   -1.55%     
==========================================
  Files          27       28       +1     
  Lines        2716     3077     +361     
==========================================
+ Hits         2471     2752     +281     
- Misses        171      217      +46     
- Partials       74      108      +34     
Flag Coverage Δ
go 89.43% <77.83%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Juliapixel Juliapixel force-pushed the h266-packet branch 2 times, most recently from 5930638 to d7cd7b3 Compare December 26, 2025 20:13
@Juliapixel Juliapixel marked this pull request as ready for review December 26, 2025 20:31
@Juliapixel Juliapixel requested a review from JoTurk December 26, 2025 20:31
@JoTurk JoTurk self-assigned this Dec 26, 2025
@JoTurk
Copy link
Member

JoTurk commented Dec 26, 2025

This is amazing julia really excited to have you involved <3
I'm reviewing and testing this tonight.

@Juliapixel Juliapixel force-pushed the h266-packet branch 3 times, most recently from eaa86a1 to 37462b3 Compare December 27, 2025 02:59
Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot, and thank you for all the fixes <3

@JoTurk
Copy link
Member

JoTurk commented Dec 27, 2025

Thank you for making the APIs private, you can merge squash merge when you want to :)

@JoTurk
Copy link
Member

JoTurk commented Dec 27, 2025

I verified this with uvgRTP.

@Juliapixel Juliapixel merged commit 5cd305b into master Dec 27, 2025
19 checks passed
@Juliapixel Juliapixel deleted the h266-packet branch December 27, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VVC/H266 packetizer and de-packetizer

3 participants