Conversation
.github/workflows/unit-tests.yml
Outdated
| extras: "" | ||
| - py: "3.13" | ||
| os: ubuntu-24.04-arm | ||
| extras: ".[stan]" |
There was a problem hiding this comment.
Can we restrict the stan stuff to one version?
It only runs on 3.10, 3.11, and 3.12, I think
There was a problem hiding this comment.
Yes, I'll restrict the .[stan] builds.
.github/workflows/unit-tests.yml
Outdated
| include: | ||
| - py: "3.9" | ||
| os: ubuntu-22.04 | ||
| extras: "" |
There was a problem hiding this comment.
Possible to have it default to "" instead of respecifying every time?
There was a problem hiding this comment.
Yes, we can do this. Good thinking.
|
Just out of curiousity: Would it be less verbose to run a full matrix but put some if() condition in that rejects certain (i,j) combos? Or is that even more typing? |
I think there end up being a large number to exclude.... I'll get a proof of concept working and then let's see if it can be streamlined at all. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9762 9762
=========================================
Hits 9762 9762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously, unit tests have only been run on x86_64 platforms, but these have included all current (and two old) python CPython version.
I propose testing:
Along with each of Ubuntu, macOS and Windows, both x86_64 and arm64 architectures, just to check there are no nasty surprises for users.
The current syntax I'm proposing is a little ugly. But it's not justifiable to do the full cartesian product of all pythons and operating systems.