Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 97 97
Lines 9762 9762
=======================================
Hits 9718 9718
Misses 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelClerx
approved these changes
Mar 5, 2026
Member
MichaelClerx
left a comment
There was a problem hiding this comment.
Looks good. Any idea if we can test it without doing a new release?
Member
Author
|
I've tested everything except the actual upload step, but there's no way to test that without a release. Could always do a subminor release to test, without any code changes? |
Member
|
Yeah probably best to do an 0.6.1 immediately then, so we can delete the token etc before we forget about it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to modern build directive
i.e. use:
rather than
Switch to trusted publishing
I have added this specific workflow as a trusted publisher on PyPI, which means we no longer require the token. Once this is tested we should delete that from the repo secrets.
Following best practice, I have split the workflow into two jobs, one for building the distribution files. This can be run on all pushes and PRs to check the wheel and sdist build. The other does the upload.