Lee1258561/sync shutdown executor#50
Open
lee1258561 wants to merge 4 commits intopinterest/main-2.52.1from
Open
Lee1258561/sync shutdown executor#50lee1258561 wants to merge 4 commits intopinterest/main-2.52.1from
lee1258561 wants to merge 4 commits intopinterest/main-2.52.1from
Conversation
Adds optional synchronized shutdown mode for streaming_split where all N shards must call shutdown_executor before the actual shutdown occurs. This enables proper coordination in distributed training scenarios. - Add sync_shutdown and split_idx parameters to shutdown_executor - Only shard 0 performs actual shutdown; others wait - Fail if same shard calls shutdown twice before sync completes - Ignore shutdown calls if called before any epoch has started - Add unit tests for the new functionality Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The shutdown state variables (_shutdown_received_from, _shutdown_complete, _shutdown_force_requested) were not reset when a new epoch started, causing duplicate shutdown errors when reusing streaming split iterators across multiple epochs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When iterators go out of scope or are deleted, cleanup is automatically triggered on the coordinator via end_epoch(), eliminating the need for explicit shutdown_executor calls between epochs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace end_epoch() with shutdown_executor(sync_shutdown=True) for epoch cleanup. This removes duplicate logic since _barrier already resets shutdown state when starting a new epoch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Additional information